build(vm): remove thiserror form deps#1279
Conversation
tdelabro
requested review from
Juan-M-V,
Oppen,
entropidelic,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 90 90
Lines 36260 36260
=======================================
Hits 35377 35377
Misses 883 883
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
Looks great, thanks @tdelabro!
IMO it's ready to merge, but please move the changelog entry up as @MegaRedHand pointed out. If you have time, could you also check my question in the other comment? Not a blocker, it's mostly curiosity.
| "parse-hyperlinks/std", | ||
| "felt/std", | ||
| "dep:num-prime", | ||
| "thiserror-no-std/std", |
There was a problem hiding this comment.
All of this makes me wonder, do we actually use anything that requires the std feature on thiserror? Did you try building without it?
There was a problem hiding this comment.
Yes.
The std version of thiserror generate the following line (which is not generated in no_std):
impl std::error::Error for <MyErrorType> {}There was a problem hiding this comment.
In the future rust will move the Error trait in core tho
tdelabro
force-pushed
the
remove-thiserror-dep
branch
from
3e350ef to
36a73d2
Compare
4 participants
Remove dep to thiserror
Description
Rather than alternating between thiserror and thiserror-no-std depending on the feature "std", we can use thiserror-no-std/std.
Checklist